Skip to content

Make Stale PR script less aggressive #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Make Stale PR script less aggressive #4737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/stale-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
- uses: actions/stale@5f858e3efba33a5ca4407a664cc011ad407f2008 # v10.1.0
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-pr-message: 'This PR was marked stale due to lack of activity. It will be closed in 7 days.'
stale-pr-message: 'This PR was marked stale. It will be closed in 30 days without additional activity.'
close-pr-message: 'Closed as inactive. Feel free to reopen if this PR is still being worked on.'
exempt-pr-labels: 'release:after-ga'
# opt out of defaults to avoid marking issues as stale
days-before-stale: -1
days-before-close: -1
# overrides the above only for pull requests
days-before-pr-stale: 7
days-before-pr-close: 7
days-before-pr-stale: 90
days-before-pr-close: 30
Comment on lines +18 to +26
Copy link
Member

@arminru arminru Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the round trip times we sometimes have in the repo, 14 days in total might indeed be too little, but going from 14 to 120 days (or 4 months) without any activity at all might be too much as well.

How about 14 + 14 days (~ 1 month without activity)?

Suggested change
stale-pr-message: 'This PR was marked stale. It will be closed in 30 days without additional activity.'
close-pr-message: 'Closed as inactive. Feel free to reopen if this PR is still being worked on.'
exempt-pr-labels: 'release:after-ga'
# opt out of defaults to avoid marking issues as stale
days-before-stale: -1
days-before-close: -1
# overrides the above only for pull requests
days-before-pr-stale: 7
days-before-pr-close: 7
days-before-pr-stale: 90
days-before-pr-close: 30
stale-pr-message: 'This PR was marked stale. It will be closed in 14 days if there is no activity.'
close-pr-message: 'Closed as inactive. Feel free to reopen if this PR is still being worked on.'
exempt-pr-labels: 'release:after-ga'
# opt out of defaults to avoid marking issues as stale
days-before-stale: -1
days-before-close: -1
# overrides the above only for pull requests
days-before-pr-stale: 14
days-before-pr-close: 14

Copy link
Member

@tigrannajaryan tigrannajaryan Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Let's double to 14+14 for now.

Copy link
Member Author

@tylerbenson tylerbenson Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While better than 7, I like the guideline from @breedx-splk that it should be longer than a long European holiday which suggests to me that 14 days is also too short. Perhaps 21 days?

Loading