Make Stale PR script less aggressive #4737
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current timeframe is way too aggressive and doesn't give folks a decent chance before threatening to close. I propose giving at least a month between marking as stale and closing.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
arminru
reviewed
Nov 25, 2025
Comment on lines
+18
to
+26
| stale-pr-message: 'This PR was marked stale. It will be closed in 30 days without additional activity.' | ||
| close-pr-message: 'Closed as inactive. Feel free to reopen if this PR is still being worked on.' | ||
| exempt-pr-labels: 'release:after-ga' | ||
| # opt out of defaults to avoid marking issues as stale | ||
| days-before-stale: -1 | ||
| days-before-close: -1 | ||
| # overrides the above only for pull requests | ||
| days-before-pr-stale: 7 | ||
| days-before-pr-close: 7 | ||
| days-before-pr-stale: 90 | ||
| days-before-pr-close: 30 |
Member
There was a problem hiding this comment.
Given the round trip times we sometimes have in the repo, 14 days in total might indeed be too little, but going from 14 to 120 days (or 4 months) without any activity at all might be too much as well.
How about 14 + 14 days (~ 1 month without activity)?
Suggested change
| stale-pr-message: 'This PR was marked stale. It will be closed in 30 days without additional activity.' | |
| close-pr-message: 'Closed as inactive. Feel free to reopen if this PR is still being worked on.' | |
| exempt-pr-labels: 'release:after-ga' | |
| # opt out of defaults to avoid marking issues as stale | |
| days-before-stale: -1 | |
| days-before-close: -1 | |
| # overrides the above only for pull requests | |
| days-before-pr-stale: 7 | |
| days-before-pr-close: 7 | |
| days-before-pr-stale: 90 | |
| days-before-pr-close: 30 | |
| stale-pr-message: 'This PR was marked stale. It will be closed in 14 days if there is no activity.' | |
| close-pr-message: 'Closed as inactive. Feel free to reopen if this PR is still being worked on.' | |
| exempt-pr-labels: 'release:after-ga' | |
| # opt out of defaults to avoid marking issues as stale | |
| days-before-stale: -1 | |
| days-before-close: -1 | |
| # overrides the above only for pull requests | |
| days-before-pr-stale: 14 | |
| days-before-pr-close: 14 |
Member
There was a problem hiding this comment.
Agree. Let's double to 14+14 for now.
Member
Author
There was a problem hiding this comment.
While better than 7, I like the guideline from @breedx-splk that it should be longer than a long European holiday which suggests to me that 14 days is also too short. Perhaps 21 days?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current timeframe is way too aggressive and doesn't give folks a decent chance before threatening to close.
I propose giving at least a month between marking as stale and closing.