Skip to content

Conversation

@legendecas
Copy link
Member

v8::Uint32::ToString does not return an empty local handle. V8 internal NumberToString does not return an empty handle. It should be safe to assert in node::Uint32ToString that this function returns a non empty string handle, and remove the redundant error recovering logics.

Refs: #53959

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Nov 25, 2025
@legendecas legendecas force-pushed the uint32-to-str branch 2 times, most recently from d43a0cf to e3d5b7a Compare November 25, 2025 00:18
@targos
Copy link
Member

targos commented Nov 25, 2025

2025-11-25T00:39:41.4286597Z application.cc:(.text+0x0): multiple definition of `node::Uint32ToString(v8::Local<v8::Context>, unsigned int)'; /home/runner/work/node/node/node/out/Release/obj.target/embedtest/src/node_snapshot_stub.o:node_snapshot_stub.cc:(.text+0x0): first defined here

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (482b191) to head (86e3b6b).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60846      +/-   ##
==========================================
+ Coverage   88.02%   88.57%   +0.54%     
==========================================
  Files         703      703              
  Lines      208268   208234      -34     
  Branches    40085    40158      +73     
==========================================
+ Hits       183337   184446    +1109     
+ Misses      16878    15810    -1068     
+ Partials     8053     7978      -75     
Files with missing lines Coverage Δ
src/node_contextify.cc 82.45% <100.00%> (+0.66%) ⬆️
src/node_webstorage.cc 74.61% <100.00%> (+1.41%) ⬆️
src/util.h 90.09% <100.00%> (+0.37%) ⬆️

... and 103 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025
@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 26, 2025
@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2025
@nodejs-github-bot nodejs-github-bot merged commit 430db0d into nodejs:main Nov 27, 2025
74 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 430db0d

@legendecas legendecas deleted the uint32-to-str branch November 27, 2025 09:19
targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60846
Refs: #53959
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants