-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
src: simply uint32 to string as it must not fail #60846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+25
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d43a0cf to
e3d5b7a
Compare
e3d5b7a to
40867ae
Compare
Member
|
40867ae to
86e3b6b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60846 +/- ##
==========================================
+ Coverage 88.02% 88.57% +0.54%
==========================================
Files 703 703
Lines 208268 208234 -34
Branches 40085 40158 +73
==========================================
+ Hits 183337 184446 +1109
+ Misses 16878 15810 -1068
+ Partials 8053 7978 -75
🚀 New features to boost your workflow:
|
targos
approved these changes
Nov 25, 2025
cjihrig
approved these changes
Nov 25, 2025
Collaborator
Collaborator
|
Landed in 430db0d |
targos
pushed a commit
that referenced
this pull request
Nov 27, 2025
PR-URL: #60846 Refs: #53959 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
vm
Issues and PRs related to the vm subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8::Uint32::ToStringdoes not return an empty local handle. V8 internalNumberToStringdoes not return an empty handle. It should be safe to assert innode::Uint32ToStringthat this function returns a non empty string handle, and remove the redundant error recovering logics.Refs: #53959