-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
src: handle indexed properties in process.env
#60826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a0fbfe to
9cda07b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60826 +/- ##
==========================================
+ Coverage 88.55% 88.56% +0.01%
==========================================
Files 703 703
Lines 208237 208264 +27
Branches 40157 40162 +5
==========================================
+ Hits 184395 184448 +53
+ Misses 15858 15827 -31
- Partials 7984 7989 +5
🚀 New features to boost your workflow:
|
|
Are there consequences from having the named property enumerator emit numeric values? (I know that's what happens currently...) |
9cda07b to
57da1d7
Compare
57da1d7 to
ef1b42c
Compare
process.envprocess.env
|
Rebased to include #60846 and fixed a typo in the commit message. |
@Renegade334 I think it only affects users of the C++ API, which allows to skip indices. |
|
Landed in 08d966c |
Closes: #60795 PR-URL: #60826 Fixes: #60795 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Closes: #60795
I'm not sure if we should treat this as a breaking change.
Before this change, indexed properties would not be intercepted, so setting them in JS would not coerce the value to a string.