test: add lint rule to forbid use of assert.ok(/regex/.test(…))

[aduh95]

No description provided.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (23c58f0) to head (4451309).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #60832   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         703      703           
  Lines      208259   208259           
  Branches    40172    40187   +15     
=======================================
+ Hits       184434   184454   +20     
+ Misses      15826    15812   -14     
+ Partials     7999     7993    -6     

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70296/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70297/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/60832
✔  Done loading data for nodejs/node/pull/60832
----------------------------------- PR info ------------------------------------
Title      test: add lint rule to forbid use of `assert.ok(/regex/.test(…))` (#60832)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:test-assert.match -> nodejs:main
Labels     test, node-api, author ready, needs-ci, commit-queue-squash
Commits    2
 - test: add lint rule to forbid use of `assert.ok(/regex/.test(…))`
 - Apply suggestions from code review
Committers 2
 - Antoine du Hamel <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/60832
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60832
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 23 Nov 2025 20:01:54 GMT
   ✔  Approvals: 4
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/60832#pullrequestreview-3500654228
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60832#pullrequestreview-3500730450
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60832#pullrequestreview-3501581347
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/60832#pullrequestreview-3504510330
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-11-24T15:39:49Z: https://ci.nodejs.org/job/node-test-pull-request/70297/
- Querying data for job/node-test-pull-request/70297/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/19682733556

[aduh95]

Landed in 4451309