test: add lint rule to forbid use of assert.ok(/regex/.test(…))

PR-URL: #60832
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

Author: aduh95

test/common/benchmark.js

@@ -42,7 +42,7 @@ function runBenchmark(name, env) {
 
     for (let testIdx = 1; testIdx < splitTests.length - 1; testIdx++) {
       const lines = splitTests[testIdx].split('\n');
-      assert.ok(/.+/.test(lines[0]));
+      assert.match(lines[0], /.+/);
 
       if (!lines[1].includes('group="')) {
         assert.strictEqual(lines.length, 2, `benchmark file not running exactly one configuration in test: ${stdout}`);

test/eslint.config_partial.mjs

@@ -109,6 +109,14 @@ export default [
           selector: 'CallExpression[callee.property.name="catch"]>:first-child:matches(CallExpression[callee.object.name="common"][callee.property.name="mustNotCall"], CallExpression[callee.name="mustNotCall"])',
           message: 'Calling `.catch(common.mustNotCall())` will not detect never-settling promises. Use `.then(common.mustCall())` instead.',
         },
+        {
+          selector: 'CallExpression[callee.type="MemberExpression"][callee.object.type="Identifier"][callee.object.name="assert"][callee.property.type="Identifier"][callee.property.name="ok"][arguments.0.type="CallExpression"][arguments.0.callee.type="MemberExpression"][arguments.0.callee.object.regex][arguments.0.callee.property.type="Identifier"][arguments.0.callee.property.name="test"]',
+          message: 'Use assert.match instead',
+        },
+        {
+          selector: 'CallExpression[callee.type="MemberExpression"][callee.object.type="Identifier"][callee.object.name="assert"][callee.property.type="Identifier"][callee.property.name="ok"][arguments.0.type="UnaryExpression"][arguments.0.operator="!"][arguments.0.argument.type="CallExpression"][arguments.0.argument.callee.type="MemberExpression"][arguments.0.argument.callee.object.regex][arguments.0.argument.callee.property.name="test"]',
+          message: 'Use assert.doesNotMatch instead',
+        },
       ],
 
       // Stylistic rules.

test/js-native-api/test_general/testV8Instanceof2.js

@@ -304,7 +304,7 @@ function InstanceTest(x, func) {
     const answer = addon.doInstanceOf(x, func);
     assert.strictEqual(correct_answers[correct_answer_index], answer);
   } catch (e) {
-    assert.ok(/prototype/.test(e));
+    assert.match(`${e}`, /prototype/);
     assert.strictEqual(correct_answers[correct_answer_index], except);
   }
   correct_answer_index++;

test/parallel/test-dns-resolver-max-timeout.js

@@ -9,7 +9,6 @@ const dgram = require('dgram');
   -1,
   1.1,
   NaN,
-  undefined,
   {},
   [],
   null,
@@ -18,11 +17,9 @@ const dgram = require('dgram');
   true,
   Infinity,
 ].forEach((maxTimeout) => {
-  try {
+  assert.throws(() => {
     new dns.Resolver({ maxTimeout });
-  } catch (e) {
-    assert.ok(/ERR_OUT_OF_RANGE|ERR_INVALID_ARG_TYPE/i.test(e.code));
-  }
+  }, /ERR_OUT_OF_RANGE|ERR_INVALID_ARG_TYPE/i);
 });
 
 const server = dgram.createSocket('udp4');

test/parallel/test-http-set-trailers.js

@@ -43,10 +43,10 @@ function testHttp10(port, callback) {
 
   c.on('end', common.mustCall(() => {
     c.end();
+    // Ensure no trailer being in HTTP/1.0 response
     assert.doesNotMatch(
       res_buffer,
       /x-foo/,
-      `No trailer in HTTP/1.0 response. Response buffer: ${res_buffer}`
     );
     callback();
   }));
@@ -69,10 +69,10 @@ function testHttp11(port, callback) {
     res_buffer += chunk;
     if (/0\r\n/.test(res_buffer)) { // got the end.
       clearTimeout(tid);
+      // Ensure trailer being in HTTP/1.1 response
       assert.match(
         res_buffer,
         /0\r\nx-foo: bar\r\n\r\n$/,
-        `No trailer in HTTP/1.1 response. Response buffer: ${res_buffer}`
       );
       callback();
     }

test/parallel/test-http2-https-fallback.js

@@ -165,7 +165,7 @@ function onSession(session, next) {
         .setEncoding('utf8')
         .on('data', (chunk) => text += chunk)
         .on('end', common.mustCall(() => {
-          assert.ok(/Missing ALPN Protocol, expected `h2` to be available/.test(text));
+          assert.match(text, /Missing ALPN Protocol, expected `h2` to be available/);
           cleanup();
         }));
     }

test/parallel/test-inspector.js

@@ -14,10 +14,10 @@ function checkListResponse(response) {
     `Expected response length ${response.length} to be ${expectedLength}.`
   );
   assert.ok(response[0].devtoolsFrontendUrl);
-  assert.ok(
-    /ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/
-      .test(response[0].webSocketDebuggerUrl),
-    response[0].webSocketDebuggerUrl);
+  assert.match(
+    response[0].webSocketDebuggerUrl,
+    /ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/,
+  );
 }
 
 function checkVersion(response) {

test/parallel/test-runner-mock-timers-date.js

@@ -62,7 +62,10 @@ describe('Mock Timers Date Test Suite', () => {
     const returned = Date();
     // Matches the format: 'Mon Jan 01 1970 00:00:00'
     // We don't care about the date, just the format
-    assert.ok(/\w{3}\s\w{3}\s\d{1,2}\s\d{2,4}\s\d{1,2}:\d{2}:\d{2}/.test(returned));
+    assert.match(
+      returned,
+      /\w{3}\s\w{3}\s\d{1,2}\s\d{2,4}\s\d{1,2}:\d{2}:\d{2}/,
+    );
   });
 
   it('should return the date with different argument calls', (t) => {

test/parallel/test-tls-server-failed-handshake-emits-clienterror.js

@@ -20,10 +20,10 @@ const server = tls.createServer({})
   }).on('tlsClientError', common.mustCall(function(e) {
     assert.ok(e instanceof Error,
               'Instance of Error should be passed to error handler');
-    assert.ok(
-      /SSL routines:[^:]*:wrong version number/.test(
-        e.message),
-      'Expecting SSL unknown protocol');
+    assert.match(
+      e.message,
+      /SSL routines:[^:]*:wrong version number/,
+    );
 
     server.close();
   }));

test/parallel/test-tls-socket-failed-handshake-emits-error.js

@@ -20,10 +20,10 @@ const server = net.createServer(common.mustCall((c) => {
     s.on('error', common.mustCall(function(e) {
       assert.ok(e instanceof Error,
                 'Instance of Error should be passed to error handler');
-      assert.ok(
-        /SSL routines:[^:]*:wrong version number/.test(
-          e.message),
-        'Expecting SSL unknown protocol');
+      assert.match(
+        e.message,
+        /SSL routines:[^:]*:wrong version number/,
+      );
     }));
 
     s.on('close', function() {