Skip to content

chore: use semver per-method import #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use semver per-method import #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import detectIndent from 'detect-indent'
import { detectNewlineGraceful as detectNewline } from 'detect-newline'
import gitHooks from 'git-hooks-list'
import isPlainObject from 'is-plain-obj'
import semver from 'semver'
import semverCompare from 'semver/functions/compare.js'
import semverMinVersion from 'semver/ranges/min-version.js'
Comment on lines +6 to +7
Copy link
Owner

@keithamus keithamus Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use exports? e.g. import {compare, minVersion} or so?

Copy link
Author

@hyperz111 hyperz111 Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use exports? e.g. import {compare, minVersion} or so?

We can, but...

$ npm run build

> [email protected] build
> esbuild index.js --bundle --platform=node --outfile=index.cjs


  index.cjs  81.2kb

⚡ Done in 124ms


const pipe =
(fns) =>
Expand Down Expand Up @@ -97,7 +98,7 @@ const sortObjectBySemver = sortObjectBy((a, b) => {
if (!bRange) {
return 1
}
return semver.compare(semver.minVersion(aRange), semver.minVersion(bRange))
return semverCompare(semverMinVersion(aRange), semverMinVersion(bRange))
})

const getPackageName = (ident) => {
Expand Down