chore: use semver per-method import #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Before $ npm run build
> [email protected] build
> esbuild index.js --bundle --platform=node --outfile=index.cjs
index.cjs 81.2kb
⚡ Done in 54msAfter $ npm run build
> [email protected] build
> esbuild index.js --bundle --platform=node --outfile=index.cjs
index.cjs 59.0kb
⚡ Done in 160ms |
Author
Author
keithamus
reviewed
Nov 27, 2025
Comment on lines
+6
to
+7
| import semverCompare from 'semver/functions/compare.js' | ||
| import semverMinVersion from 'semver/ranges/min-version.js' |
Owner
There was a problem hiding this comment.
Can we use exports? e.g. import {compare, minVersion} or so?
Author
There was a problem hiding this comment.
Can we use exports? e.g.
import {compare, minVersion}or so?
We can, but...
$ npm run build
> [email protected] build
> esbuild index.js --bundle --platform=node --outfile=index.cjs
index.cjs 81.2kb
⚡ Done in 124ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
semverper-method import for make theindex.cjssize is smaller.