-
Notifications
You must be signed in to change notification settings - Fork 13
test: add test cases for date input empty string handling #5441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
18
commits into
main
Choose a base branch
from
copilot/sub-pr-5440
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1f270c6
docs: adapted solution
mfranzke fc4cdc1
fix(input[type="date"]): resetting a field by the empty string
mfranzke db1ffc3
Create orange-eyes-pump.md
mfranzke a7129d0
Clarify behavior of DBInput with empty string input
mfranzke 78e080b
Initial plan
Copilot 6a08b67
test: add test for date input clearing with empty string
0346ecd
chore: add blob-report to .gitignore and remove test artifact
7987395
Refactor writeValue condition for clarity
mfranzke 21b4a25
Fix condition in writeValue method for value checks
mfranzke 1160368
test: another try
mfranzke 55a044c
refactor: we need to test for our component, not the native element
mfranzke 19d3fa7
refactor: another try
mfranzke e516c72
fix: correct date input tests to use proper component remounting
e1d351a
Merge branch 'main' into 5439-dbinput-inserting-an-empty-string-doesn…
michaelmkraus e3e3663
Apply suggestions from code review
mfranzke 5deff5f
refactor: provoke test failure
mfranzke f56b1ca
Merge branch '5439-dbinput-inserting-an-empty-string-doesnt-empty-dat…
mfranzke 890529f
Fix condition in writeValue method for date types
mfranzke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@db-ux/ngx-core-components": patch | ||
| --- | ||
|
|
||
| DBInput: inserting an empty string doesn't reset/empty date or time related form fields |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.