-
Notifications
You must be signed in to change notification settings - Fork 13
test: add test cases for date input empty string handling #5441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Co-authored-by: mfranzke <[email protected]>
Co-authored-by: mfranzke <[email protected]>
|
@copilot the test now runs into a timeout. Please fix it and test it yourself previous to assuming your task is done. |
Co-authored-by: mfranzke <[email protected]>
Fixed in commit e516c72. The tests were failing (not timing out) because they tried to directly manipulate the component's value property, which doesn't work correctly in React's controlled component model. Updated the tests to properly remount the component with new value props. All 11 tests now pass successfully. |
…t-empty-date-form-fields
Co-authored-by: Michael Kraus <[email protected]>
…e-form-fields' into copilot/sub-pr-5440
Proposed changes
This PR adds test coverage for the date input empty string reset behavior from PR #5440 and addresses Playwright test artifact management.
resolves #5440 (related)
Types of changes
Further comments
Background
This PR initially attempted to add test coverage for the date input empty string reset behavior from PR #5440. After review and feedback from @mfranzke, the tests were identified as ineffective because they manipulated the DOM directly rather than properly testing React component behavior. The tests have been corrected to properly validate the fix.
Changes Made
blob-report/to.gitignore: When Playwright tests run with the blob reporter (used in CI environments), they generate artifacts inblob-report/directories. These test artifacts should not be committed to the repository.Test Status
All 11 tests now pass successfully:
The blob reporter configuration can be found in
showcases/playwright.config.tswhere it's enabled whenprocess.env.CIis set.❤️ Thank you!
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/copilot/sub-pr-5440