Skip to content

Made from_file pickle loading more robust #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Made from_file pickle loading more robust #702

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1772b0d
Made from_file pickle loading more robust
tbuckworth Aug 21, 2024
0b36c67
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 21, 2024
716ef19
added warning to missing parameters in from_file
tbuckworth Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pysr/sr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,6 +1013,22 @@ def from_file(
base_equation_file = os.path.basename(model.equation_file_)
model.equation_file_ = os.path.join(base_dir, base_equation_file)

# Get constructor parameters and default values
params = inspect.signature(model.__init__).parameters

# Filter for missing parameters excluding kwargs
missing_params = {
k: v
for k, v in params.items()
if k not in model.__dict__.keys()
and v.name != "self"
and v.kind != v.VAR_KEYWORD
}

# Assign missing attributes
for k, v in missing_params.items():
setattr(model, k, v)

# Update any parameters if necessary, such as
# extra_sympy_mappings:
model.set_params(**pysr_kwargs)
Expand Down