Made from_file pickle loading more robust #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added backwards compatibility for loading models pickled under older versions. Adds missing parameters with their default values.
for more information, see https://pre-commit.ci
Owner
MilesCranmer
left a comment
MilesCranmer
left a comment
There was a problem hiding this comment.
Looks good. I would like to have a unit test for this just so we can verify it works. Although I’m not immediately sure how to do that. Maybe there’s a way to have a separate Python process install an old version of PySR, run it, and then attempt to load the old model in the current code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added backwards compatibility for loading models pickled under older versions.
Adds missing parameters with their default values.
See issue #700