Skip to content

Removed the always keyword for DeprecationWarning in hbonds_autocorrel.py #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+33 −8
Open

Removed the always keyword for DeprecationWarning in hbonds_autocorrel.py #5159

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4af4973
Removed the always keyword for DeprecationWarning in hbonds_autocorre…
spyke7 Nov 26, 2025
725b055
Reformatted with black
spyke7 Nov 26, 2025
66f4217
Merge branch 'develop' into hbonds_warning_fix
spyke7 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions package/CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,21 @@ Changes
Deprecations


11/26/25 IAlibay, orbeckst, marinegor, tylerjereddy, ljwoods2, marinegor, spyke7

* 2.11.0

Fixes
* Fixes the DeprecationWarning in hbonds_autocorrel.py so as the warning
can be suppressed in mdacli which are not needed(Issue #5157, PR #5159)

Changes
* In the hbonds\hbonds_autocorrel.py, removed the always keyword. And keeping
the message same (Issue #5157, PR #5159)

Deprecations


Comment on lines +37 to +51
Copy link
Member

@RMeli RMeli Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the CHANGELONG entries alonside the 2.11.0 version above, not add a new entry for your PR. See #5160.

11/24/25 IAlibay, orbeckst, marinegor, tylerjereddy, ljwoods2, marinegor, spyke7

* 2.11.0
Expand Down
14 changes: 6 additions & 8 deletions package/MDAnalysis/analysis/hbonds/hbond_autocorrel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,12 @@
"""
import warnings

with warnings.catch_warnings():
warnings.simplefilter("always", DeprecationWarning)
wmsg = (
"This module was moved to "
"MDAnalysis.analysis.hydrogenbonds.hbond_autocorrel; "
"hbonds.hbond_autocorrel will be removed in 3.0.0."
)
warnings.warn(wmsg, category=DeprecationWarning)
wmsg = (
"This module was moved to "
"MDAnalysis.analysis.hydrogenbonds.hbond_autocorrel; "
"hbonds.hbond_autocorrel will be removed in 3.0.0."
)
warnings.warn(wmsg, category=DeprecationWarning)

from MDAnalysis.lib.util import deprecate

Expand Down
Loading