Removed the always keyword for DeprecationWarning in hbonds_autocorrel.py #5159
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5159 +/- ##
===========================================
- Coverage 92.72% 92.72% -0.01%
===========================================
Files 180 180
Lines 22472 22470 -2
Branches 3188 3188
===========================================
- Hits 20837 20835 -2
Misses 1177 1177
Partials 458 458 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RMeli
requested changes
Nov 26, 2025
Comment on lines
+34
to
+48
| 11/26/25 IAlibay, orbeckst, marinegor, tylerjereddy, ljwoods2, marinegor, spyke7 | ||
|
|
||
| * 2.11.0 | ||
|
|
||
| Fixes | ||
| * Fixes the DeprecationWarning in hbonds_autocorrel.py so as the warning | ||
| can be suppressed in mdacli which are not needed(Issue #5157, PR #5159) | ||
|
|
||
| Changes | ||
| * In the hbonds\hbonds_autocorrel.py, removed the always keyword. And keeping | ||
| the message same (Issue #5157, PR #5159) | ||
|
|
||
| Deprecations | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
You need to add the CHANGELONG entries alonside the 2.11.0 version above, not add a new entry for your PR. See #5160.
Contributor
Author
|
@marinegor I resolved the conflict. And do I have to fix any other things? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5157
Changes made in this Pull Request:
@marinegor @PicoCentauri Updated the hbonds_autocorrel.py please check it!
PR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5159.org.readthedocs.build/en/5159/