Skip to content

#7012 Fix: Can't turn grid off #9101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

#7012 Fix: Can't turn grid off #9101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b014caa
write settings out if reapply_settings was successful
andrewvarga Nov 28, 2025
15f97b0
Update snapshots
github-actions[bot] Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions rust/kcl-lib/src/execution/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,8 +650,9 @@ impl ExecutorContext {
reapply_settings,
ast: changed_program,
} => {
if reapply_settings
&& self
let mut reapply_failed = false;
if reapply_settings {
if self
.engine
.reapply_settings(
&self.settings,
Expand All @@ -660,8 +661,19 @@ impl ExecutorContext {
grid_scale,
)
.await
.is_err()
{
.is_ok()
{
cache::write_old_ast(GlobalState::with_settings(
Copy link
Contributor Author

@andrewvarga andrewvarga Nov 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously we never called write_old_ast in this CheckImportsOnly arm of the match after reapply_settings so the value was never updated in the cache, so next time the grid changed it was compared against an outdated cached value.

This is similar code to further below in this function which also calls write_old_ast after reapply_settings.

cached_state.clone(),
self.settings.clone(),
))
.await;
} else {
reapply_failed = true;
}
}

if reapply_failed {
(true, program, None)
} else {
// We need to check our imports to see if they changed.
Expand Down
Loading