-
Notifications
You must be signed in to change notification settings - Fork 93
#7012 Fix: Can't turn grid off #9101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| { | ||
| .is_ok() | ||
| { | ||
| cache::write_old_ast(GlobalState::with_settings( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we never called write_old_ast in this CheckImportsOnly arm of the match after reapply_settings so the value was never updated in the cache, so next time the grid changed it was compared against an outdated cached value.
This is similar code to further below in this function which also calls write_old_ast after reapply_settings.
CodSpeed Performance ReportMerging #9101 will not alter performanceComparing Summary
Benchmarks breakdown
Footnotes
|
Fixes #7012
Could be reproduced by having a project which has an import:
Make sure you have the file being imported "cube.kcl" in this case that can contain anything:
Then:
I was trying to add a test, it was a bit tricky for me at first without using a screenshot based test or without using mocks..