zfsbootmenu: add and use recursive_umount function #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdykstra
force-pushed
the
recursive-umount
branch
from
ce45f6d to
17e9f19
Compare
ahesford
reviewed
Nov 19, 2025
zfsbootmenu/lib/zfsbootmenu-core.sh
Outdated
Comment on lines
2288
to
2289
| ret=0 | ||
| if ! umount -R "${mountpoint}" >/dev/null 2>&1 ; then |
Member
There was a problem hiding this comment.
Suggested change
| ret=0 | |
| if ! umount -R "${mountpoint}" >/dev/null 2>&1 ; then | |
| umount -R "${mountpoint}" >/dev/null 2>&1 && return | |
| ret=0 |
Then you can drop the big if indent.
zdykstra
force-pushed
the
recursive-umount
branch
from
17e9f19 to
eb9b283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
recursive_umountfunction and use in the chroot helper and when unmounting filesysems just before kexec. This is in place for #770 .