Use tsserver to drive vue-typescript-plugin (fix Vue file completion) #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puremourning
force-pushed
the
vue-tsserver
branch
from
3532533 to
1ae9112
Compare
Member
|
how can I test this simply? I don't vue |
Member
|
I tried the test app in ycm-core/lsp-examples repo and got this: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything in the title ; as it currently is, completion in
*.vuefiles is not working - not at all out of the box, and very broken if trying to use modernvue-language-serverthe same way one used to usevolarorvls- I'm not 100% sure but despite it being the same project asvolar/vls(or a fork), I suspect it really expects to be driven throughtsservernowadays - this seems to work perfectly without the user even needing to change anything in their.vimrc.This change is
EDIT: I'm sure in an ideal world there would be a fully separate
build.pyargument for Vue, so that we wouldn't need to "pollute" thetsserver/package.jsonfile with Vue-specific stuff, but I figured it might be overkill and doesn't make a whole lot of difference anyway (~4MB innode_modules).