Add input field to specify a database for the login process. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe mode disappeared with php 5.4 (September 2015), and version 7.1 or above is required. https://www.php.net/manual/en/features.safe-mode.php
Notes: - "CREATE TABLE WITHOUT OIDS" continues to work, for now - "SHOW default_with_oids" continues to work, for now
This is mostly just refactoring Nirgals patch to use a standard capability function. I also short-circuited default_with_oid check since it will always show false in >=PG12, so this saves a round trip. This also adds a comment in the config file that show oids is no longer supported. This could lead to a slight difference in running instalations, but since it does not affect any code/behavior, not going to bump the config version.
.build_tests.php no longer exists: There is no need to exclude it.
Note that the minimized version is not considered "source code".
- Replaced .click(function) by .on('click', function)
- Replaced .click() by .trigger('click')
- Replaced .live(event, function) by .on(event, function)
- Replaced $(document).ready(function) by $(function)
- Replaced .bind/.unbind by .on/.off
- Replaced keypress events by keydown events, so that up/down keys get
supported again.
Thanks to the jquery-migrate project.
For version 14, we point to the /devel/ docs, since that version is currently in dev. I also bumped the fall through to point to v14, arguably we could instead point to /current/, but any current version will work, so I think devel is more likely.
Based on code and suggestions from @cathysax, ultimately I used the internal pg_has_role function to test whether a user has ownership rights based on group membership. I actually check for 'USAGE' rights, since that implies the role has rights without need to `set role`, which users wouldn't be able to do with a normal PPA login. Loosely tested back to 9.5. This fixes phppgadmin#102
There was a non-UTF8 character in Marek Černocký last name. Moreover, he was already listed.
The addition of support for PostgreSQL 9.6 and above neglected to change the `Postgres94` class to inherit from `Postgres95` instead of the latest `Postgres` class. This change restores the chain of inheritance, so that `Postgres94` and classes below see overridden methods from `Postgres95` and above.
Added input field to specify a database for the login process.
Added input field to specify a database for the login process.
Added input field to specify a database for the login process.
Added input field to specify a database for the login process.
|
@tachtler: Can you add your changes into this one? Thanks in advance. |
Author
|
@Neustradamus: I already submitted a pull request on March 16, 2021 for the repository: https://github.com/phppgadmin/phppgadmin. Thank you for your reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input field to specify a database for the login process.