Remove width and height from plot_results and plot_annotations #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bw4sz
changed the title
Collaborator
Author
|
@copilot simplify the tests into one simple test. Be concise and minimal, this is a small feature. |
Contributor
4 tasks
bw4sz
force-pushed
the
fix/visualize-convert-sv-rootdir
branch
from
4b355af to
c08e1a0
Compare
ethanwhite
reviewed
Nov 14, 2025
Member
ethanwhite
left a comment
ethanwhite
left a comment
There was a problem hiding this comment.
All of the changes removing height and width look good, but I'm unclear as to how the new resolved_root code on lines 209-225 relates to the rest of the PR.
Collaborator
Author
|
This was the same general logic and motivation for #1210 The plot and predict functions shouldn't have to deal with all this uncertainty in what the data looks like. All of this is going to be handled by the read_file, with the exception of the edge case where the image exists only in memory and not on disk. Updated code and we should wait until 1210 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on MillionTrees I noticed an annoying patterns for visualizing polygon data, we asked the user to separately specify the width and height of the image, even though we had the image. This was partially fixed in #834 but not fully, since the arguments still remained.