Skip to content

[Azure Pipelines] Enable experimental Server Timing in Safari TP #16177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2019
Merged

[Azure Pipelines] Enable experimental Server Timing in Safari TP #16177

merged 1 commit into from
Apr 11, 2019

Conversation

@foolip
Copy link
Member

@foolip foolip commented Apr 1, 2019

@foolip
Copy link
Member Author

foolip commented Apr 1, 2019

@cvazac can you review? I've only enabled it for Safari Technology Preview to match what we do for other browsers – experimental features enabled in experimental/preview channels only.

@foolip foolip mentioned this pull request Apr 1, 2019
Open
@foolip foolip force-pushed the foolip/ExperimentalServerTimingEnabled branch 2 times, most recently from e6e23c3 to 1f96ca8 Compare April 2, 2019 07:59
@foolip
Copy link
Member Author

foolip commented Apr 2, 2019

I've started https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=11891 to see what the difference in results will be.

@foolip
Copy link
Member Author

foolip commented Apr 2, 2019

Results are in, but the Server Timing tests seem unaffected:
https://wpt.fyi/results/server-timing?diff&filter=ADC&run_id=5471855615934464&run_id=4825746438619136

@cvazac have you confirmed this setting to work locally?

@foolip
Copy link
Member Author

foolip commented Apr 2, 2019

I might have found a fix, trying https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=12008 again.

@foolip
Copy link
Member Author

foolip commented Apr 3, 2019

Sweet, that worked!

https://wpt.fyi/results/server-timing?diff&filter=ADC&run_id=5471855615934464&run_id=5475323030274048

Also no regression in infrastructure/ tests, so I didn't mess that up either.

@foolip foolip assigned gsnedders and unassigned jgraham Apr 3, 2019
@wpt-pr-bot wpt-pr-bot added the docs label Apr 3, 2019
@foolip
Copy link
Member Author

foolip commented Apr 5, 2019

@jgraham the failure to run lint in https://tools.taskcluster.net/groups/Kh4_OybISQuKNPB4YITH1A/tasks/U2P2bZSHQMaKzY6yazHi9g/runs/0/logs/public%2Flogs%2Flive.log is a bit mysterious to me. Have you seen this before?

I'm going to squash and rebase this branch and see what happens, since I don't see the same failure on all other PRs.

@foolip foolip force-pushed the foolip/ExperimentalServerTimingEnabled branch from d480ee4 to a236a2a Compare April 5, 2019 10:20
@foolip
Copy link
Member Author

foolip commented Apr 5, 2019

Now it's fine. @gsnedders can you review?

@gsnedders gsnedders merged commit d11578d into master Apr 11, 2019
@gsnedders gsnedders deleted the foolip/ExperimentalServerTimingEnabled branch April 11, 2019 13:17
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
@foolip
[Azure Pipelines] Enable experimental Server Timing in Safari TP (#16177
00167e1 
)

Like web-platform-tests/results-collection#621.

Also update documentation to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsnedders gsnedders gsnedders approved these changes

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@sideshowbarker sideshowbarker Awaiting requested review from sideshowbarker

Assignees

@gsnedders gsnedders

Labels

Azure Pipelines ci docs infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@foolip @gsnedders @jgraham @wpt-pr-bot