Align type and media attributes from SVGStyleElement with HTMLStyleElement #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement - type and media no longer have an initial value - type is obsoleted
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Aug 26, 2025
https://bugs.webkit.org/show_bug.cgi?id=297909 Reviewed by NOBODY (OOPS!). See w3c/svgwg#1001 This aligns SVGStyleElement type and media to use pure attribute reflection which matches how HTMLStyleElement works. This aligns WebKit with Firefox/Gecko. * LayoutTests/imported/w3c/web-platform-tests/svg/styling/attr-style-media-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/styling/attr-style-media.html: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/styling/attr-style-type-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/svg/styling/attr-style-type.html: Added. * Source/WebCore/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::type const): Deleted. (WebCore::SVGStyleElement::setType): Deleted. (WebCore::SVGStyleElement::media const): Deleted. (WebCore::SVGStyleElement::setMedia): Deleted. * Source/WebCore/svg/SVGStyleElement.h: * Source/WebCore/svg/SVGStyleElement.idl:
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Aug 27, 2025
https://bugs.webkit.org/show_bug.cgi?id=297909 Reviewed by NOBODY (OOPS!). See w3c/svgwg#1001 This aligns SVGStyleElement type and media to use pure attribute reflection which matches how HTMLStyleElement works. This aligns WebKit with Firefox/Gecko.
webkit-commit-queue
pushed a commit
to lukewarlow/WebKit
that referenced
this pull request
Aug 28, 2025
https://bugs.webkit.org/show_bug.cgi?id=297909 Reviewed by Tim Nguyen. See w3c/svgwg#1001 This aligns SVGStyleElement type and media to use pure attribute reflection which matches how HTMLStyleElement works. This aligns WebKit with Firefox/Gecko. Canonical link: https://commits.webkit.org/299252@main
Jarred-Sumner
pushed a commit
to oven-sh/WebKit
that referenced
this pull request
Aug 29, 2025
https://bugs.webkit.org/show_bug.cgi?id=297909 Reviewed by Tim Nguyen. See w3c/svgwg#1001 This aligns SVGStyleElement type and media to use pure attribute reflection which matches how HTMLStyleElement works. This aligns WebKit with Firefox/Gecko. Canonical link: https://commits.webkit.org/299252@main
Member
|
https://wpt.fyi/results/svg/styling/attr-style-media.html Firefox and Safari are now aligned. @lukewarlow I have the feeling that the beginning of your issues has been eaten by a cookie monster. Is there a PR? You would like to make on the SVG spec? |
Member
Author
|
This is the PR. I'll fix OP in a bit. |
Member
|
/me put his eyes in his eye sockets again. Sorry. :D |
karlcow
reviewed
Oct 9, 2025
Member
|
RESOLUTION: 'type' attribute to be deprecated. 'media' attribute resolution deferred for now. |
dirkschulze
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align type and media
attributes from
SVGStyleElement with HTMLStyleElement
This aligns the behaviour with Firefox and with the HTMLStyleElement.
WebKit Bug:
https://bugs.webkit.org/show_bug.cgi?id=297909(Fixed to match this behaviour)Firefox Bug: N/A (Current behaviour)
Chromium Bug: https://issues.chromium.org/u/1/issues/441253575
WPT Changes: web-platform-tests/wpt#54529
Fixes #996 and #995