Skip to content

feat: improve the Fullscreen functionality and orientation for mobile devices #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −3
Open

feat: improve the Fullscreen functionality and orientation for mobile devices #9067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/js/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2131,7 +2131,7 @@ class Player extends Component {
*/
documentFullscreenChange_(e) {
const targetPlayer = e.target.player;

console.log(targetPlayer, "lll");
// if another player was fullscreen
// do a null check for targetPlayer because older firefox's would put document as e.target
if (targetPlayer && targetPlayer !== this) {
Expand All @@ -2140,10 +2140,23 @@ class Player extends Component {

const el = this.el();
let isFs = document[this.fsApi_.fullscreenElement] === el;

let playerContainer = targetPlayer.el_;
// console.log(isFss, 'kk')
if (!isFs && el.matches) {
isFs = el.matches(':' + this.fsApi_.fullscreen);
}
// in mobile screen if the video width is longer than video height then it would be in landscale
if((targetPlayer.el_.querySelector('video').videoHeight
< targetPlayer.el_.querySelector('video').videoWidth) && screen.orientation && screen.orientation.lock){
// console.log("mobile full screen")
// if (isLandscape ) {
screen.orientation.lock('landscape').catch(err => {
console.warn('Orientation lock failed:', err);
});
// }
}
// console.log(targetPlayer.el_.querySelector('video').videoHeight, targetPlayer.el_.querySelector('video').videoWidth );


this.isFullscreen(isFs);
}
Expand All @@ -2169,7 +2182,7 @@ class Player extends Component {
this.removeClass('vjs-ios-native-fs');
});
}
this.isFullscreen(data.isFullscreen);
this.isFullscreen(data.isFullscreen, event);
}
}

Expand Down Expand Up @@ -2938,6 +2951,7 @@ class Player extends Component {
* - Nothing when setting
*/
isFullscreen(isFS) {

if (isFS !== undefined) {
const oldValue = this.isFullscreen_;

Expand Down