fix: uses data-active state as reka-ui applies it on NavigationMenuLink #1592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reka-ui sets
data-activeattribute depending on condition. previous implementation used css class that checked for data-[active=true] which was never a matchπ Linked issue
#1591
β Type of change
π Description
styles on NavigationMenuLink use a tailwind data-attribute selector data-[active=true] to apply styles for the active item.
However, reka-ui either sets the attribute data-active or not. i.e., data-[active=true] is never a match
https://github.com/unovue/reka-ui/blob/1e0670da1d9cf9652cb4cf89aa2015265dbd60d0/packages/core/src/NavigationMenu/NavigationMenuLink.vue#L60C8-L60C19
this pr replaces those selectors with
data-activeresolves #1591
πΈ Screenshots (if appropriate)
π Checklist