Skip to content

Conversation

@benkroeger
Copy link
Contributor

reka-ui sets data-active attribute depending on condition. previous implementation used css class that checked for data-[active=true] which was never a match

πŸ”— Linked issue

#1591

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

styles on NavigationMenuLink use a tailwind data-attribute selector data-[active=true] to apply styles for the active item.
However, reka-ui either sets the attribute data-active or not. i.e., data-[active=true] is never a match

https://github.com/unovue/reka-ui/blob/1e0670da1d9cf9652cb4cf89aa2015265dbd60d0/packages/core/src/NavigationMenu/NavigationMenuLink.vue#L60C8-L60C19

this pr replaces those selectors with data-active

resolves #1591

πŸ“Έ Screenshots (if appropriate)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

reka-ui sets `data-active` attribute depending on condition. previous implementation used css class that checked for data-[active=true] which was never a match
@sadeghbarati sadeghbarati merged commit 1e2fe17 into unovue:dev Nov 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NavigationMenuLink uses data-active selector that is different from what reka-ui defined

2 participants