fix(sidebar): prevent overflow in SidebarSeparator with horizontal orientation #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ientation Updated SidebarSeparator component to use `data-[orientation=horizontal]:w-auto` instead of `w-auto` to prevent overflow issues caused by underlying Separator classes. The change makes the width override more specific, only applying to horizontal separators, which prevents conflicts with other Separator styling.
Author
|
@zernonia solved merge conflicts for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed overflow issue in
SidebarSeparatorcomponent by updating the width class to usedata-[orientation=horizontal]:w-autoinstead ofw-auto. This makes the width overridemore specific, only applying to horizontal separators, which prevents conflicts with other
Separator styling.
Fixes #1486
Changes
SidebarSeparator.vuein all styles (default, new-york, new-york-v4)w-autotodata-[orientation=horizontal]:w-autoto prevent overflow issuesRelated
This fix is related to shadcn-ui/ui#8498 which addresses the same
issue in the main shadcn-ui/ui library.
Test plan