Skip to content

Upgrade react material UI #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Upgrade react material UI #88

wants to merge 12 commits into from

Conversation

@vinuganesan
Copy link
Collaborator

@vinuganesan vinuganesan commented Jun 7, 2024 •
edited
Loading

Updated React JS, Material-UI and other packages

@vinuganesan vinuganesan requested a review from dfrancisc June 7, 2024 05:50
@vinuganesan vinuganesan marked this pull request as ready for review June 10, 2024 07:10
@dfrancisc
Copy link
Collaborator

dfrancisc commented Jun 12, 2024

In read only mode , the toolbar still works:
image
This is an issue I also found, and seems to be a problem with latest version of slate. Latest version with this problem fixed is 0.66.0 ( as stated in master branch). So, I suggest one of the following solutions:

  1. Use 0.66.0 version with latest version of unicef material ui if possible
  2. Add a prop "readOnly" to toolbar component and make sure the client passes it from the caller project/component

@vinuganesan
Copy link
Collaborator Author

vinuganesan commented Jun 12, 2024 •
edited
Loading

@dfrancisc I fixed this issue by passing readOnly prop. Please check

@vinuganesan vinuganesan reopened this Jun 12, 2024
dfrancisc
dfrancisc reviewed Jan 27, 2025
View reviewed changes
@dfrancisc dfrancisc self-requested a review January 27, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfrancisc dfrancisc dfrancisc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vinuganesan @dfrancisc