change: apply codec preferences via native browser API #2180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change: - Use the native transceiver.setCodecPreferences instead of manually modifying the SDP.
- Relay on the browser's SDP negotiation to set the correct codecs instead of manually modifying the SDP.
kpchoy
approved these changes
Nov 25, 2025
mhuynh5757
approved these changes
Nov 25, 2025
|
|
||
| class SafariRTCPeerConnection extends EventTarget { | ||
| constructor(configuration) { | ||
| constructor(configuration, options = {}) { |
Contributor
There was a problem hiding this comment.
I see that the Chrome RTCPeerConnection has a default value for configuration where this Safari one does not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Jira link(s)
Description
Replace manual SDP manipulation for codec preferences with native
RTCRtpTransceiver.setCodecPreferences()to align with modern practices for codec negotiation.Burndown
Before review
npm test