Add Gitlab V3 Detector #4563
Open
Add Gitlab V3 Detector #4563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great work, @mustansir14. Let's add the v3 to engine defaults as well. |
pkg/detectors/gitlab/v3/gitlab_v3.go
Outdated
|
|
||
| var ( | ||
| defaultClient = common.SaneHttpClient() | ||
| keyPat = regexp.MustCompile(`\b(glpat-[a-zA-Z0-9\-=_]{27,300}.[0-9a-z]{2}.[a-z0-9]{9})\b`) |
Contributor
There was a problem hiding this comment.
optional: It's probably worth adding a comment and a link to the gitlab commit that sets the regex, just so anyone curious about it can more easily pull up that info.
Though, it's also included as a part of the PR, so the information is available, which is great! A comment would just make it easier.
Contributor
Author
There was a problem hiding this comment.
Good point. Added.
kashifkhan0771
approved these changes
Nov 25, 2025
nabeelalam
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves #4551 by introducing a V3 detector for Gitlab. Newly generated Gitlab PATs have a different format than what we are looking for in v1 and v2.
Thanks to @trufflesteeeve, we found Gitlab's merged PR that introduced this change. The regex is now made flexible to match what they have.
Checklist:
make test-community)?make lintthis requires golangci-lint)?