Fix [ -z $var clauses without quotes
#1161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me (I would suggest to have all variables in the form |
ericzolf
added a commit
to rdiff-backup/rdiff-backup
that referenced
this pull request
Feb 7, 2020
Only tags really looking like release versions are deployed to PyPI and Windows wheels aren't deployed until travis-ci/dpl#1161 and travis-ci/dpl#1162 are fixed.
Contributor
Author
|
@ericzolf You can test it by adding the following to the corresponding |
ericzolf
added a commit
to rdiff-backup/rdiff-backup
that referenced
this pull request
Feb 9, 2020
* Replace Windows bdist through bdist_wheel for Travis - The bdist output is rather useless for PyPI whereas a Windows wheel could be uploaded. * Add deployment to pypi and pypi test for sdist and bdist_wheel * Temporarily remove the Windows bdist_wheel deployment and filter tag * Only tags really looking like release versions according to PEP440 are deployed to PyPI * Windows wheels aren't deployed until travis-ci/dpl#1161 and travis-ci/dpl#1162 are fixed. DEV: automate via Travis deployment pipeline release to PyPI and Test PyPI.
ericzolf
pushed a commit
to rdiff-backup/rdiff-backup
that referenced
this pull request
Feb 17, 2020
# Conflicts: # lib/dpl/provider/pypi.rb # spec/provider/pypi_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://travis-ci.community/t/pypi-deploy-failing-on-windows-couldnt-install-pip-setuptools-twine-or-wheel/6338/5