Skip to content

Conversation

@youssef-horo
Copy link

@youssef-horo youssef-horo commented Nov 21, 2025

Checklist

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.

  • The page description(s) have links to documentation or a homepage.

  • The page(s) follow the content guidelines.

  • The page(s) follow the style guide.

  • The PR contains at most 5 new pages.

  • The PR is authored by me, or has been human-reviewed if it was created with AI or machine translation software.

  • The PR title conforms to the recommended templates.

  • Version of the command being documented (if known): Latest version (as per dolt documentation)

Reference issue: #5471

@github-actions github-actions bot added new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers. labels Nov 21, 2025
@Managor Managor mentioned this pull request Nov 21, 2025
33 tasks
Copy link
Member

@dmmqz dmmqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dolt conflicts doesn't seem to be a command by itself:

$ dolt conflicts
Valid commands for dolt conflicts are
                 cat - Writes out the table conflicts.
             resolve - Removes rows from list of conflicts

Split dolt-conflicts into two separate pages for the actual subcommands:
- dolt-conflicts-cat: Display conflicts for a table
- dolt-conflicts-resolve: Resolve conflicts with --ours, --theirs, or --both

Fixes reviewer feedback:
- dolt conflicts is not a standalone command
- Fixed link anchors to point to correct documentation sections

Closes tldr-pages#5471
@youssef-horo youssef-horo force-pushed the dolt-conflicts-documentation branch from 475f6e0 to d4e1d3d Compare November 23, 2025 17:24
@youssef-horo
Copy link
Author

Hi @dmmqz, thanks for the review! I've addressed your feedback:

  1. Split into separate subcommand pages: Since dolt conflicts is not a standalone command, I've created two separate pages:

    • dolt-conflicts-cat.md - documents dolt conflicts cat for displaying conflicts
    • dolt-conflicts-resolve.md - documents dolt conflicts resolve with the --ours, --theirs, and --both options
  2. Fixed link anchors: Updated the links to use the correct anchors:

    • #dolt-conflicts-cat
    • #dolt-conflicts-resolve

Both links have been verified and work correctly. The old dolt-conflicts.md page has been removed.

Ready for another review!

@Managor
Copy link
Member

Managor commented Nov 24, 2025

Just use a single dolt conflicts page that documents both.
Also, please don't force push.

@Managor
Copy link
Member

Managor commented Nov 28, 2025

@youssef-horo Please address my comment

@Managor
Copy link
Member

Managor commented Dec 1, 2025

Shame commit history wasn't preserved. Otherwise I would have just reverted the change and pushed the original page.

@Managor Managor closed this Dec 1, 2025
@youssef-horo youssef-horo deleted the dolt-conflicts-documentation branch December 2, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new command Issues requesting creation of a new page or PRs adding a new page for a command. review needed Prioritized PRs marked for reviews from maintainers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants