Split out tests from test/staging/Intl402/Temporal/old/non-iso-calendars-buddhist.js #4736
+1,561
−364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
catamorphism
commented
Nov 29, 2025
catamorphism
commented
- Add more tests for add/subtract/since/until
- Add tests for inLeapYear, monthsInYear, daysInMonth properties
- Add tests checking that leap months are disallowed
- Add tests for wrapping at the end of the month in with
ptomato
approved these changes
Dec 1, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Just the semicolons, feel free to merge after fixing those
Comment on lines
23
to
25
| const date25401230 = Temporal.PlainDate.from({ year: 2540, monthCode: "M12", day: 30, calendar }); | ||
| const date25401230 = Temporal.PlainDate.from({ year: 2540, monthCode: "M12", day: 30, calendar }) | ||
| const date25550101 = Temporal.PlainDate.from({ year: 2555, monthCode: "M01", day: 1, calendar });; | ||
| const date25551007 = Temporal.PlainDate.from({ year: 2555, monthCode: "M10", day: 7, calendar });; |
Contributor
There was a problem hiding this comment.
Looks like something got messed up with semicolons here
…ars-buddhist.js * Add more tests for add/subtract/since/until * Add tests for inLeapYear, monthsInYear, daysInMonth properties * Add tests checking that leap months are disallowed * Add tests for wrapping at the end of the month in with
catamorphism
force-pushed
the
buddhist-calendar-from-staging
branch
from
68895a3 to
64ed424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.