Reference code fixes around TypeError/RangeError ordering #3188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec mandates that the shape of the fields property bag must be checked (and a TypeError thrown if incorrect) before any RangeError conditions are checked. See #3166
As per #2940 this belongs in NonISOResolveFields, before any RangeError conditions are checked.
I have gotten confused by the lack of resolveLunisolarMonth here several times, so add a comment explaining that it's intentional.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3188 +/- ##
==========================================
+ Coverage 96.49% 96.66% +0.17%
==========================================
Files 22 22
Lines 10305 10321 +16
Branches 1846 1857 +11
==========================================
+ Hits 9944 9977 +33
+ Misses 311 294 -17
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This fixes a bug where adding 1 year 0 months would skip applying the overflow option. Brings the polyfill calendar code in line with the spec text of proposal-intl-era-monthcode. (For example, in 2020-02-29[u-ca=gregory] + P1Y with overflow: "reject")
Collaborator
Author
|
Tacked on another bug fix to make the polyfill correctly implement NonISODateAdd. |
Ms2ger
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these in preparation for tc39/proposal-intl-era-monthcode#90 - two cases where the reference code does not implement the spec correctly.
Also updates test262 to pull in the most recent tests (including coverage for these fixes.)