Skip to content

Editorial: Remove early return in BubbleRelativeDuration #3179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −5
Open

Editorial: Remove early return in BubbleRelativeDuration #3179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions spec/duration.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1767,12 +1767,11 @@ <h1>
</dd>
</dl>
<emu-alg>
1. If _smallestUnit_ is _largestUnit_, return _duration_.
1. Let _largestUnitIndex_ be the ordinal index of the row of <emu-xref href="#table-temporal-units"></emu-xref> whose "Value" column contains _largestUnit_.
1. Let _smallestUnitIndex_ be the ordinal index of the row of <emu-xref href="#table-temporal-units"></emu-xref> whose "Value" column contains _smallestUnit_.
1. Let _unitIndex_ be _smallestUnitIndex_ - 1.
1. Let _unitIndex_ be the ordinal index of the row of <emu-xref href="#table-temporal-units"></emu-xref> whose "Value" column contains _smallestUnit_.
1. Let _done_ be *false*.
1. Repeat, while _unitIndex_ ≥ _largestUnitIndex_ and _done_ is *false*,
1. Repeat, while _unitIndex_ > _largestUnitIndex_ and _done_ is *false*,
1. Set _unitIndex_ to _unitIndex_ - 1.
1. Let _unit_ be the value in the "Value" column of <emu-xref href="#table-temporal-units"></emu-xref> in the row whose ordinal index is _unitIndex_.
1. If _unit_ is not ~week~, or _largestUnit_ is ~week~, then
1. If _unit_ is ~year~, then
Expand All @@ -1797,7 +1796,6 @@ <h1>
1. Set _duration_ to CombineDateAndTimeDuration(_endDuration_, 0).
1. Else,
1. Set _done_ to *true*.
1. Set _unitIndex_ to _unitIndex_ - 1.
1. Return _duration_.
</emu-alg>
</emu-clause>
Expand Down