test: Token gated communities - TC 7128 #7144
Open
+420
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test_admin_token_permissions_with_valid_tokens
- cleanup and add additional logging
- test_owner_edits_visible_before_and_after_minting_owner_token
- test_owner_edits_visible_before_and_after_minting_owner_token
romanzac
changed the title
Member
Jenkins BuildsClick to see older builds (147)
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #7144 +/- ##
============================================
- Coverage 60.04% 34.97% -25.07%
============================================
Files 813 798 -15
Lines 113391 111318 -2073
============================================
- Hits 68080 38938 -29142
- Misses 38489 67570 +29081
+ Partials 6822 4810 -2012
Flags with carried forward coverage won't be shown. Click here to find out more. |
- test_owner_edits_visible_before_and_after_minting_owner_token
- test_owner_edits_visible_before_and_after_minting_owner_token
…7128' into test/token-gated-communities-tc-7128 # Conflicts: # tests-functional/tests/test_wakuext_community_token_permissions.py
Member
✔️ status-go/prs/tests-nwaku/PR-7144#3 🔹 ~28 min 🔹 b22ec06 🔹 📦 tests package |
fbarbu15
reviewed
Dec 3, 2025
Contributor
fbarbu15
left a comment
fbarbu15
left a comment
There was a problem hiding this comment.
Thanks, left just some small comments
| def test_owner_edits_visible_before_and_after_minting_owner_token(self): | ||
| """Test that owner edits are visible before and after minting the owner token""" | ||
|
|
||
| def edit_community(community_id): |
Contributor
There was a problem hiding this comment.
any reason to have this function nested inside the test? If we move it outside, we keep the test more compact
| == RequestToJoinState.RequestToJoinStatePending.value, | ||
| ) | ||
|
|
||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
do we need the sleep since we wait for signal above?
Contributor
Author
There was a problem hiding this comment.
I agree with you. I would rather pull state (old school approach) with timeout or wait for push - quality signal. It looks backend coherence with signals has still some room for improvement. We are discussing it here #7161 (comment)
| new_name2, new_description2 = edit_community(community_id) | ||
| logger.info(f"New name2: {new_name2}, new description2: {new_description2}") | ||
|
|
||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
can we avoid the sleep by looking for a signal?
Contributor
Author
There was a problem hiding this comment.
It was there more for demo reasons. Fixed at 4705f43
fbarbu15
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test case 7128 of functional tests to cover token-gated communities.
Tests Included
Issues discovered
Closes #7128