[6.x] Combobox: Prevent options being cut off & add scrollbar #13211
+117
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where options might get cut off in a Combobox dropdown. It also adds a scrollbar to improve usability when there's lots of options:
CleanShot.2025-11-28.at.11.50.41.mp4
Unfortunately, because we need to virtualize the options to help with performance, it means that only the visible options actually exist in the DOM.
This means we can't rely on the browser's built-in scrollbar, we have to build our own. It's a little bit of a pain, but 🤷♂️
Closes #13205