[5.x] Fix nocache tag not replacing element correctly #13177
Merged
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue caused by #12929, where the nocache tag wasn't replacing the
<span class="nocache">element as expected.In my testing, this PR seems to fix both issues, in addition to supporting shadow root elements (which the previous PR added support for).
This is the template I was testing with:
{{ nocache }} <p class="mb-6">only element</p> {{ /nocache }} <ul class="flex items-center mb-6"> {{ nocache }} {{ nav:header }} <li> <a class="py-1.5 px-3 rounded-md {{ if is_current }} bg-white font-medium {{ else }} text-blue-600 hover:bg-white {{ /if }}" href="{{ url }}">{{ title }}</a> </li> {{ /nav:header }} {{ /nocache }} </ul> {{ nocache }} <div> <template shadowrootmode="open">...</template> </div> {{ /nocache }}Fixes #13114
Fixes #13141