-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: persist thinking blocks display to KV and indicate its current display state in the command_list (resolves #4582) #4810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Resolved conflicts in TUI config schema to include both copy_on_select and diff_style fields - Updated Go SDK to include both new TUI configuration options - Maintained copy-on-select feature implementation while incorporating upstream changes
|
Updated SDK types, tests should now pass correctly when re-run. |
|
Ohhhhh... I see that the format action is the one adding the trailing whitespace on package.json files. I'll stop trying to 'fix' (air quotes) it. |
…rrent state ("Hide thinking" / "Show thinking" instead of just "Toggle thinking blocks")
c7e0fac to
47adf14
Compare
|
idk if this will work or break something but i'd prefer not to add config option and instead just keep the kv change u did |
|
/oc remove the config.ts changes and typegen change, and the config mention, instead ONLY keep the change that relates to KV and the toggle thinking blocks title change / persistance addition |
|
Perfect! The typegen file is unchanged. Now let me verify the complete set of changes by viewing what we're keeping: Summary of changes:
The changes now focus solely on:
|
Co-authored-by: rekram1-node <[email protected]>
|
/oc undo the changes made to config.ts and types.gen.ts in this pr |
|
Perfect! All changes have been successfully undone. Both
The config option and auto-generated type changes have been completely removed. |
|
@rekram1-node No objection to that change here, works for me. Came to offer to make the requested change, but it seems that by the time I arrived at the web page you'd already put the robots to work taking care of it. Let me know if there's anything I can do to help this one along, cheers! |
|
Haha yeah I use the gh action to make edits sometimes. rn it is using haiku which isn't the smartest model but it does a decent job with edits |
packages/sdk/js/src/gen/types.gen.ts
Outdated
| /** | ||
| * Default visibility of thinking blocks in TUI | ||
| */ | ||
| thinking_visibility?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/oc revert this change (delete these lines)
| export type TUI = z.infer<typeof TUI> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/oc revert this change (delete these lines)
… display state in the command_list (resolves sst#4582) (sst#4810) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <[email protected]> Co-authored-by: Aiden Cline <[email protected]>
… display state in the command_list (resolves sst#4582) (sst#4810) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com> Co-authored-by: rekram1-node <[email protected]> Co-authored-by: Aiden Cline <[email protected]>


Resolves #4582.
This PR does two (closely connected) things:
command_listmenu is changed to either "show thinking blocks" or "hide thinking blocks" in accord with its current state.