Improve infrastructure documentation #1261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
infra-docs
branch
from
7541c86 to
9d54876
Compare
zackgalbreath
approved these changes
Nov 21, 2025
jjnesbitt
reviewed
Nov 21, 2025
| - Pushes the requisite Flux manifests to the spack-infrastructure github repository (internally, via the Terraform github provider). This is done via a personal access token (PAT) associated with the `spackbot` github account that is stored in AWS Secrets Manager and dynamically retrieved by Terraform at runtime. See [here for an example commit](https://github.com/spack/spack-infrastructure/commit/dd42896897b7c0c0e3e2bca66ae58433fcf734fa). | ||
| - **Kubernetes**: Kubernetes yaml manifests for the EKS cluster | ||
| - For this we use the kubectl provider (https://registry.terraform.io/providers/alekc/kubectl/latest/docs) and the helm provider (https://registry.terraform.io/providers/hashicorp/helm/latest/docs). | ||
| - We try to use Flux/GitOps to manage the Kubernetes cluster (i.e., by committing k8s yaml manifests to `k8s/`) as much as possible, but sometimes it is cleaner to manage some manifests with the Terraform kubectl provider. This is true mainly for manifests that have to reference resources that are managed by Terraform. A concrete examples of this is using [the `kubectl_manifest` resource to deploy a `Secret` resource for RDS credentials](./modules/spack_aws_k8s/gitlab_db.tf), which enables us to reference the RDS credentials using Terraform interpolation instead of hardcoding them in a manifest. |
Collaborator
There was a problem hiding this comment.
This link doesn't seem to resolve. It tries to open the repo on a branch called modules/spack_aws_k8s/gitlab_db.tf, instead of a file. Is that just because it's still a PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some documentation for the cloud infrastructure, particularly Terraform and how Flux works.