Promotions: Fix default calculator fields partial bug and make PercentWithCap calculator available in the UI

[mamhoff]

Summary

This adds the PercentWithCap calculator to the list of available line item promotion calculators, and also fixes the default calculator fields partial to not try to send :humanize to a Symbol.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have localized any and all user-facing strings that I added to the source code.
• I have used clear, explanatory commit messages.

The following are not always needed:

• 📖 I have updated the README to account for my changes.
• 📑 I have documented new code with YARD.
• 🛣️ I have opened a PR to update the guides.
• ✅ I have added automated tests to cover my changes.
• 📸 I have attached screenshots to demo visual changes.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.46%. Comparing base (ea4bb50) to head (7e1de2d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6381   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         975      975           
  Lines       20335    20335           
=======================================
  Hits        18192    18192           
  Misses       2143     2143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tvdeyen]

Can we extract the fix from the added calculator? The partial fix can be back ported to 4.6, but the calculator is only present in main (4.7.0.dev) and cannot be ported.

[mamhoff]

Can we extract the fix from the added calculator? The partial fix can be back ported to 4.6, but the calculator is only present in main (4.7.0.dev) and cannot be ported.

The calculator is present in 4.6, and it's the only calculator that we ship that needs the fallback partial - that's why both commits are together, I can't really test the problem without the calculator.

Cf 09c3ec5

[tvdeyen]

Can we extract the fix from the added calculator? The partial fix can be back ported to 4.6, but the calculator is only present in main (4.7.0.dev) and cannot be ported.

The calculator is present in 4.6, and it's the only calculator that we ship that needs the fallback partial - that's why both commits are together, I can't really test the problem without the calculator.

Cf 09c3ec5

Ah, I was was misreading 6b2f3df (which is only present in main). Apologies.

[tvdeyen]

The PR title is doing a good job in confusing as well

Promotions: Add PercentWithCap calculator, fix default calculator fields partial bug

@mamhoff Can you rephrase this please?

[mamhoff]

The PR title is doing a good job in confusing as well

Promotions: Add PercentWithCap calculator, fix default calculator fields partial bug

@mamhoff Can you rephrase this please?

Done

[solidus-bot]

💔 All backports failed

Status	Branch	Result
❌	v4.6	Backport failed because of merge conflicts You might need to backport the following PRs to v4.6: - Fix appearance and specs for option value condition - Promotions: Pass product-picker to option-value-picker

Manual backport

To create the backport manually run:

backport --pr 6381

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

[mamhoff]

💚 All backports created successfully

Status	Branch	Result
✅	v4.6

Questions ?

Please refer to the Backport tool documentation