Fixed types #629
Open
Fixed types #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Is this everything that is needed or do I still need to write a Changelog? |
Collaborator
|
I messed around with the lint error in #630, and I might've accidentally fixed this? Could you check? If still broken, this needs a quick rebase 🙂 |
Author
|
Tried method in #630 but it doesn't work. 
I'm using typescript from Bun. |
Collaborator
|
Fair - mind rebasing? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #614
As
PrometheusContentTypeis assigned toRegistryContentType, the typescript will automatically excludeOpenMetricsContentTypefromRegistryContentTypeinRegistry. So to solve this issue, we can just manually tell typescript that provided value can bePrometheusContentTypeorOpenMetricsContentType.