Define splunk.trace.snapshot.profiling Baggage Key and Propagation Details #342
Conversation
|
|
||
| ### Context Propagation | ||
|
|
||
| The trace snapshot volume MUST be propagated using the OpenTelemetry [`baggage`](https://opentelemetry.io/docs/concepts/signals/baggage/). |
There was a problem hiding this comment.
https://github.com/signalfx/gdi-specification/blob/main/specification/integration_context.md uses headers to propagate info. Why should we use baggage here?
There was a problem hiding this comment.
I'm unfamiliar with the constraints of that effort but for trace snapshot profiling we utilize the Baggage so the signal will propagate beyond services instrumented with agents that do not have trace snapshotting capabilities.
Is the ask to include the WHY in the document?
There was a problem hiding this comment.
Is the ask to include the WHY in the document?
no, I was just curious why we are using different solutions for a similar problem. Note that with java api users can easily clear existing baggage when using Baggage.builder().put("mybaggage", "foo").build().makeCurrent(); instead of Baggage.current().toBuilder().put("mybaggage", "foo").build().makeCurrent();
cc @breedx-splk
2 participants
This PR defines how a trace should be selected for snapshotting and how that selection decision should be propagated to other agents.