Skip to content

Conversation

@swankjesse
Copy link

First time contributor checklist

Contributor checklist

  • Android Emulator with API 36.1
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

I’d like to help migrate Signal from RxJava to MutableStateFlow.

A reasonable place to start is SignalWebSocket. That class has an Observable, state that is used from Java, in SignalProxyUtil. So I’d like to convert that class from Java to Kotlin as a first step. (Java code cannot collect on a MutableStateFlow because it doesn’t support suspend!)

@greyson-signal
Copy link
Contributor

Thank you, much appreciated! The change will go out in 7.67 next week (normally we have weekly releases, but Thanksgiving :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants