Skip to content

Added Commitlint and Changelog #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Symphoria wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Commitlint and Changelog #18

Symphoria wants to merge 3 commits into from

Conversation

@Symphoria
Copy link
Contributor

@Symphoria Symphoria commented Mar 10, 2018

No description provided.

@Symphoria
chore: added Commitlint and Changelog to the Project
3509028 
also added Commitizen for easily writing commit messages

ISSUES CLOSED: sendilkumarn#10
@Symphoria Symphoria force-pushed the enhance/commitlint branch from f01b846 to 3509028 Compare March 10, 2018 10:54
@Symphoria Symphoria changed the title Enhance/commitlint Added Commitlint and Changelog Mar 10, 2018
dhruvdutt
dhruvdutt suggested changes Mar 10, 2018
View reviewed changes
CHANGELOG.md Outdated

## New Features

* add circle ci batch ([626fa2f](https://github.com/Symphoria/webpack-addons-pwa/commit/626fa2f))
Copy link
Contributor

@dhruvdutt dhruvdutt Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the repo to point upstream sendilkumarn/webpack-addons-pw?

@Symphoria
Copy link
Contributor Author

Symphoria commented Mar 10, 2018

@sendilkumarn @dhruvdutt Made the changes. Please review

dhruvdutt
dhruvdutt suggested changes Mar 10, 2018
View reviewed changes
Copy link
Contributor

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some minor changes. 👍

.cz-config.js Outdated
scopes: [],
types: [
{ value: "feat", name: "feat: A new feature" },
{ value: "tests", name: "tests: Tests, jest, binTestCases, etc" },
Copy link
Contributor

@dhruvdutt dhruvdutt Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use jest. Also, you can clear binTestCases.

.cz-config.js Outdated
{ value: "tests", name: "tests: Tests, jest, binTestCases, etc" },
{ value: "docs", name: "docs: Documentation" },
{ value: "misc", name: "misc: Other formats like tweaks and such" },
{ value: "chore", name: "chore: Updating docs, linting, grunt tasks etc" },
Copy link
Contributor

@dhruvdutt dhruvdutt Mar 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean grunt.

dhruvdutt
dhruvdutt approved these changes Mar 10, 2018
View reviewed changes
Copy link
Contributor

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 @Symphoria Going good.

sendilkumarn
sendilkumarn requested changes Mar 11, 2018
View reviewed changes
Copy link
Owner

@sendilkumarn sendilkumarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor changes

.eslintignore
@@ -0,0 +1 @@
build No newline at end of file
Copy link
Owner

@sendilkumarn sendilkumarn Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more blank line here

Copy link
Contributor Author

@Symphoria Symphoria Mar 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

CHANGELOG.md
@@ -0,0 +1,86 @@
<a name="1.0.0"></a>
# 1.0.0 (2018-03-10)
Copy link
Owner

@sendilkumarn sendilkumarn Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why it is shown as 1.0.0 ?

Copy link
Contributor Author

@Symphoria Symphoria Mar 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, 1.0.0 is the version specified in package.json. Do I increase the version in package.json? @sendilkumarn

build/changelog-generator/index.js
process.stderr.write(`
> Be sure to have the latest git tags locally:
git fetch --tags

Copy link
Owner

@sendilkumarn sendilkumarn Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this extra line

Copy link
Contributor Author

@Symphoria Symphoria Mar 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@sendilkumarn
Copy link
Owner

sendilkumarn commented Jul 21, 2018

@Symphoria did you plan to work on this ?

@rishabh3112
Copy link
Contributor

rishabh3112 commented Aug 6, 2018

@Symphoria @sendilkumarn there are few minor changes left in this PR, would be nice if this PR is resolved!!

rishabh3112 referenced this pull request Aug 11, 2018
@sendilkumarn
Update CHANGELOG.md
14d35b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sendilkumarn sendilkumarn sendilkumarn requested changes

+1 more reviewer

@dhruvdutt dhruvdutt dhruvdutt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Symphoria @sendilkumarn @rishabh3112 @dhruvdutt