Skip to content

Conversation

@ori-kron-wis
Copy link
Collaborator

close #3626

@ori-kron-wis ori-kron-wis self-assigned this Nov 30, 2025
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.4.x on-merge: backport to 1.4.x label Nov 30, 2025
@ori-kron-wis
Copy link
Collaborator Author

Also added or settings.batch_size in case batch_size is not set inside data loaders, for all models.

Consider to set the same batch_size for all models by default (right now, it varies between models, from 64 to 512)

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.59%. Comparing base (39abdb9) to head (160481c).

❗ There is a different number of reports uploaded between BASE (39abdb9) and HEAD (160481c). Click for more details.

HEAD has 64 uploads less than BASE
Flag BASE (39abdb9) HEAD (160481c)
67 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3629       +/-   ##
===========================================
- Coverage   86.72%   74.59%   -12.13%     
===========================================
  Files         225      225               
  Lines       21593    21594        +1     
===========================================
- Hits        18726    16109     -2617     
- Misses       2867     5485     +2618     
Files with missing lines Coverage Δ
src/scvi/dataloaders/_data_splitting.py 95.52% <ø> (ø)
...ernal/contrastivevi/_contrastive_data_splitting.py 89.47% <ø> (ø)
src/scvi/external/contrastivevi/_model.py 80.20% <ø> (ø)
src/scvi/external/cytovi/_model.py 62.24% <ø> (-18.88%) ⬇️
src/scvi/model/_multivi.py 80.13% <ø> (ø)
src/scvi/model/_totalvi.py 88.02% <ø> (ø)
src/scvi/model/base/_jaxmixin.py 94.44% <100.00%> (+0.15%) ⬆️
src/scvi/model/base/_pyromixin.py 92.39% <ø> (-4.35%) ⬇️
src/scvi/model/base/_training_mixin.py 73.70% <100.00%> (-17.85%) ⬇️

... and 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch_size setting problem

2 participants