Skip to content

Added code snippet to explain how to use splash behind proxy #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added code snippet to explain how to use splash behind proxy #589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions splash/examples/proxyEg.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
function main(splash)
Copy link
Contributor

@lucywang000 lucywang000 Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "use-proxy.lua" would be a better name (the convention in the examples/ folder is to use dash-separated file name, not camel case).

splash:on_request(function(request)
request:set_proxy{
host = "10.3.100.207",
port = 8080,
username = splash.args.username,
password = splash.args.password,
}
end)
local url = splash.args.url
assert(splash:go(url))
Copy link
Contributor

@lucywang000 lucywang000 Mar 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't make sense to create a local variable and only use it once. Simply assert(splash:go(splash.args.url)) would do.

assert(splash:wait(0.5))
return {
html = splash:html(),
png = splash:png(),
har = splash:har(),
}
end