Skip to content

Conversation

@nex3
Copy link
Contributor

@nex3 nex3 commented Nov 20, 2025

Closes #401

@nex3 nex3 requested a review from pamelalozano16 November 20, 2025 22:20
@ntkme
Copy link
Contributor

ntkme commented Nov 21, 2025

I think there’s a bit more than just this:

Invalid workflow file: .github/workflows/ci.yml#L1
(Line: 135, Col: 5): Unexpected value 'uses'

@nex3
Copy link
Contributor Author

nex3 commented Nov 21, 2025

Good catch. I think I've fixed that now, although of course we'll need to try a deploy to find out.

working-directory: sass-spec

deploy_npm:
name: Deploy npm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can keep the name here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably true, but we don't have it in other packages and it's essentially redundant with the job identifier anyway.

Copy link

@pamelalozano16 pamelalozano16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nex3 nex3 merged commit 2bdc2f0 into main Nov 25, 2025
17 checks passed
@nex3 nex3 deleted the provenance branch November 25, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No sass-embedded new versions landing

4 participants