Skip to content

feat(typegen)!: return same case when generating types #11330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: next-major
Choose a base branch
from
Open

feat(typegen)!: return same case when generating types #11330

wants to merge 1 commit into from
+79 −8

Conversation

@sgulseth
Copy link
Member

@sgulseth sgulseth commented Nov 28, 2025 •
edited
Loading

Description

Detect casing and return the generated type name with the same casing. If we can't detect it we fall back to camelCase

What to review

Testing

yes

Notes for release

TypeGen(Breaking!): Return generated type names in same case as the query name case.

@vercel
Copy link

vercel bot commented Nov 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
page-building-studio Ready Ready Preview Comment Dec 3, 2025 2:23pm
test-studio Ready Ready Preview Comment Dec 3, 2025 2:23pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
e2e-studio Ignored Ignored Dec 3, 2025 2:23pm
studio-workshop Ignored Ignored Preview Dec 3, 2025 2:23pm
test-next-studio Ignored Ignored Dec 3, 2025 2:23pm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-jnjwk9ehg.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-jnjwk9ehg.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-11330-chromium-19896990428 || pr-11330-firefox-19896990428 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-11330-chromium-19896990428
  SANITY_E2E_DATASET_FIREFOX=pr-11330-firefox-19896990428

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

📊 Playwright Test Report

Waiting for E2E tests to finish…

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

⚡️ Editor Performance Report

Deploying studio and running performance tests…

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 44.39% 64014 / 144202
🔵 Statements 44.39% 64014 / 144202
🔵 Functions 48.2% 3410 / 7074
🔵 Branches 79.32% 13005 / 16394
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/@sanity/codegen/src/casing.ts 100% 100% 100% 100%
packages/@sanity/codegen/src/_exports/index.ts 0% 0% 0% 0% 1-9
Generated in workflow #47010 for commit 2442700 by the Vitest Coverage Report Action

@sgulseth sgulseth force-pushed the feat/cldx-4359/detect-type-casing branch from c54f8dd to 6a946ed Compare November 28, 2025 09:57
@sgulseth sgulseth marked this pull request as ready for review December 2, 2025 09:32
@sgulseth sgulseth requested review from a team as code owners December 2, 2025 09:32
@sgulseth sgulseth requested review from a team and pedrobonamin and removed request for a team and pedrobonamin December 2, 2025 09:32
@kbrabrand kbrabrand force-pushed the feat/cldx-4359/detect-type-casing branch from d3b0b82 to 2442700 Compare December 3, 2025 11:44
kbrabrand
kbrabrand requested changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@kbrabrand kbrabrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Added a suggestion on handling camel case before snake case, but other than that it looks 👍

@kbrabrand kbrabrand changed the base branch from main to next-major December 3, 2025 12:25
@bjoerge bjoerge force-pushed the next-major branch 2 times, most recently from f4962bd to c32c601 Compare December 3, 2025 14:06
@sgulseth sgulseth requested a review from kbrabrand December 3, 2025 14:07
@sgulseth sgulseth force-pushed the feat/cldx-4359/detect-type-casing branch from 2442700 to 28c0e9b Compare December 3, 2025 14:08
@sgulseth sgulseth force-pushed the feat/cldx-4359/detect-type-casing branch from 28c0e9b to 3452935 Compare December 3, 2025 14:13
@sgulseth sgulseth force-pushed the feat/cldx-4359/detect-type-casing branch from 3452935 to 8ad49d5 Compare December 3, 2025 14:17
@bjoerge bjoerge changed the title feat(typegen): return same case when generating types feat(typegen)!: return same case when generating types Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbrabrand kbrabrand Awaiting requested review from kbrabrand

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgulseth @kbrabrand