Rollup of 8 pull requests #149370

Zalathar · 2025-11-27T04:47:13Z

Successful merges:

float::clamp: make treatment of signed zeros unspecified #149238 (float::clamp: make treatment of signed zeros unspecified)
implement Iterator::{exactly_one, collect_array} #149270 (implement Iterator::{exactly_one, collect_array})
Suggest _bytes versions of endian-converting methods #149295 (Suggest _bytes versions of endian-converting methods)
fix rustdoc search says “Consider searching for "null" instead.” #149324 #149332 (fix rustdoc search says “Consider searching for "null" instead.” rustdoc search says “Consider searching for "null" instead.” #149324)
Fix typo in comment. #149349 (Fix typo in comment.)
Tidying up UI tests [3/N] #149353 (Tidying up UI tests [3/N])
Document that build.description affects symbol mangling and crate IDs #149355 (Document that build.description affects symbol mangling and crate IDs)
Enable CI download for windows-gnullvm #149360 (Enable CI download for windows-gnullvm)

r? @ghost
@rustbot modify labels: rollup

Relocate issues/issue-51154.rs to closures/box-generic-closure.rs Relocate issues/issue-51515.rs to borrowck/assignment-to-immutable-ref.rs Relocate issues/issue-53348.rs to mismatched_types/deref-string-assign.rs Relocate issues/issue-52717.rs to pattern/match-enum-struct-variant-field-missing.rs Relocate issues/issue-53300.rs to type/cannot-find-wrapper-with-impl-trait.rs

…nieu float::clamp: make treatment of signed zeros unspecified Fixes rust-lang#83984 by explicitly documenting that we do not specify the treatment of signed zeros in `clamp`. `@rust-lang/libs-api` Is this what you'd like to see? Cc `@tgross35` `@thomcc`

…on, r=Mark-Simulacrum implement `Iterator::{exactly_one, collect_array}` As per rust-lang#149266

…ulacrum Suggest _bytes versions of endian-converting methods As pointed out [in this article](https://purplesyringa.moe/blog/ntoh-hton-is-a-bad-api/), the `int.to_be()`/`int.to_le()` functions are technically returning a wrong type, because endian-specific representations of integers and Rust's always-native-endian integers are different things. I wanted to make the docs state more directly that byte swapping will result in the type having a "wrong" value, but I wasn't sure whether to delve into the special case of palindrome-like values (`0x12343412`) not changing. I've updated the docs to suggest `{to,from}_[lb]e_bytes()` instead. These methods use `[u8; _]` for endian-specific representations, which is a different type than the native-endian `u16`/`u32`/`u64`, and this is a type-safety improvement.

…eGomez fix rustdoc search says “Consider searching for "null" instead.” rust-lang#149324 fix rust-lang#149324 Now builds the “generic parameter” correction banner from discrete sentence fragments and appends the “Consider searching …” clause only when query.proposeCorrectionTo is non-null, so the UI no longer renders null as the suggested type. Adds a PARSED section with two queries: one typo (Result<SomeTraiz>) that still produces a concrete suggestion and one fully unknown type (Result<NoSuchTrait>) that leaves proposeCorrectionTo null.

…rk-Simulacrum Fix typo in comment.

Tidying up UI tests [3/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed prior to merge. part of rust-lang#133895 Relocate 5 tests from tests/ui/issues

…3557, r=Mark-Simulacrum Document that `build.description` affects symbol mangling and crate IDs Addresses issue rust-lang#103557 Adds warning to `bootstrap.example.toml` explaining that changing build.description affects crate IDs and symbol name mangling, which makes compiled artifacts incompatible across different values. As ```@Mark-Simulacrum``` points out, "if you're building with different settings, we really can't guarantee compatibility in any nice way." This documentation attempts to make that clear. This is my first contribution here, so any feedback would be greatly appreciated!

…Simulacrum Enable CI download for windows-gnullvm This works now!

Zalathar · 2025-11-27T04:47:58Z

Rollup of everything not in #149368.

@bors r+ rollup=never p=5

bors · 2025-11-27T04:48:00Z

📌 Commit 7b50aa6 has been approved by Zalathar

It is now in the queue for this repository.

bors · 2025-11-27T07:30:29Z

⌛ Testing commit 7b50aa6 with merge 7b9905e...

bors · 2025-11-27T10:47:05Z

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 7b9905e to main...

rust-timer · 2025-11-27T10:49:23Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149238	float::clamp: make treatment of signed zeros unspecified	`a3493906853cc41c5d6f8ba7466794c7d704dc46` (link)
#149270	implement `Iterator::{exactly_one, collect_array}`	`84c0594132ba1618e04e8b9109f476df6688d776` (link)
#149295	Suggest _bytes versions of endian-converting methods	`9b75bd7e48b8c0d784fa6cda5ff01f8b9de1ce7f` (link)
#149332	fix rustdoc search says “Consider searching for "null" in…	`58708d5d90e9f5121e143e23277adbaa29336b2b` (link)
#149349	Fix typo in comment.	`09ab8bd322df316b3c0a57d9dd0af333fa2b7ccc` (link)
#149353	Tidying up UI tests [3/N]	`5d9eecfd460397cd072ff7f65b7e7714faa1f306` (link)
#149355	Document that `build.description` affects symbol mangling a…	`88bb99150e829f0cbc45cd56c4889dfa5e24f1a7` (link)
#149360	Enable CI download for windows-gnullvm	`517a6435b3dd9a75625fc513bf203c788597f20c` (link)

previous master: a4175159da

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-27T10:50:16Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a417515 (parent) -> 7b9905e (this PR)

Test differences

Show 3432 test diffs

Stage 1

[ui] tests/ui/borrowck/assignment-to-immutable-ref.rs: [missing] -> pass (J1)
[ui] tests/ui/closures/box-generic-closure.rs: [missing] -> pass (J1)
[ui] tests/ui/issues/issue-51154.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-51515.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-52717.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-53300.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-53348.rs: pass -> [missing] (J1)
[ui] tests/ui/mismatched_types/assign-deref-string-to-string.rs: [missing] -> pass (J1)
[ui] tests/ui/pattern/match-enum-struct-variant-field-missing.rs: [missing] -> pass (J1)
[ui] tests/ui/type/cannot-find-wrapper-with-impl-trait.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/borrowck/assignment-to-immutable-ref.rs: [missing] -> pass (J0)
[ui] tests/ui/closures/box-generic-closure.rs: [missing] -> pass (J0)
[ui] tests/ui/issues/issue-51154.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-51515.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-52717.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-53300.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-53348.rs: pass -> [missing] (J0)
[ui] tests/ui/mismatched_types/assign-deref-string-to-string.rs: [missing] -> pass (J0)
[ui] tests/ui/pattern/match-enum-struct-variant-field-missing.rs: [missing] -> pass (J0)
[ui] tests/ui/type/cannot-find-wrapper-with-impl-trait.rs: [missing] -> pass (J0)

Additionally, 3412 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7b9905edb4df3aeaabd0d6cd0d4c09b183d7d965 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 6748.5s -> 9564.5s (+41.7%)
dist-apple-various: 3925.6s -> 3384.3s (-13.8%)
aarch64-gnu-llvm-20-2: 2507.4s -> 2181.2s (-13.0%)
dist-aarch64-apple: 6603.1s -> 7384.5s (+11.8%)
i686-gnu-2: 6223.9s -> 5528.3s (-11.2%)
aarch64-msvc-2: 4803.5s -> 5286.9s (+10.1%)
x86_64-rust-for-linux: 3045.7s -> 2742.4s (-10.0%)
x86_64-gnu-gcc: 3399.2s -> 3063.0s (-9.9%)
i686-gnu-nopt-1: 8254.3s -> 7438.0s (-9.9%)
i686-gnu-1: 8291.7s -> 7490.7s (-9.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-27T13:20:08Z

Finished benchmarking commit (7b9905e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.1%, 0.2%]	2

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.7%, -2.1%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.7%, 2.0%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.7%, 2.0%]	2

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	4
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	34
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	4

Bootstrap: 472.621s -> 470.06s (-0.54%)
Artifact size: 386.88 MiB -> 386.96 MiB (0.02%)

jdonszelmann and others added 18 commits November 24, 2025 15:04

implement and test Iterator::{exactly_one, collect_array}

699184b

fixup warnings around the compiler

f201752

Suggest _bytes versions of endian-converting methods

3faad7c

fix

48bd321

float::clamp: make treatment of signed zeros unspecified

69d3218

use string

29639e3

Fix typo in comment.

e49f961

Warn about build.description compatibility issues

4af0b97

Enable CI download for windows-gnullvm

4408573

Rollup merge of rust-lang#149270 - jdonszelmann:exact-length-collecti…

3a62a46

…on, r=Mark-Simulacrum implement `Iterator::{exactly_one, collect_array}` As per rust-lang#149266

Rollup merge of rust-lang#149349 - m-ou-se:fmt-arg-comment-typo, r=Ma…

4fca7c5

…rk-Simulacrum Fix typo in comment.

Rollup merge of rust-lang#149353 - reddevilmidzy:t3, r=Kivooeo

b89d254

Tidying up UI tests [3/N] > [!NOTE] > Intermediate commits are intended to help review, but will be squashed prior to merge. part of rust-lang#133895 Relocate 5 tests from tests/ui/issues

Rollup merge of rust-lang#149360 - mati865:push-rnmttvktztwp, r=Mark-…

7b50aa6

…Simulacrum Enable CI download for windows-gnullvm This works now!

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 27, 2025

bors merged commit 7b9905e into rust-lang:main Nov 27, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 27, 2025

Zalathar deleted the rollup-6fkk5x4 branch November 27, 2025 10:57

bors mentioned this pull request Nov 27, 2025

Add String<A> type with custom allocator parameter #149328

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 8 pull requests #149370

Rollup of 8 pull requests #149370

Zalathar commented Nov 27, 2025 •

edited by rustbot

Loading

Uh oh!

Zalathar commented Nov 27, 2025

Uh oh!

bors commented Nov 27, 2025

Uh oh!

bors commented Nov 27, 2025

Uh oh!

bors commented Nov 27, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 27, 2025

Uh oh!

github-actions bot commented Nov 27, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Rollup of 8 pull requests #149370

Rollup of 8 pull requests #149370

Conversation

Zalathar commented Nov 27, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Nov 27, 2025

Uh oh!

bors commented Nov 27, 2025

Uh oh!

bors commented Nov 27, 2025

Uh oh!

bors commented Nov 27, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 27, 2025

Uh oh!

github-actions bot commented Nov 27, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 27, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Zalathar commented Nov 27, 2025 •

edited by rustbot

Loading