Port the #![windows_subsystem] attribute to the new attribute system
#149363
+203
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
rust/sasha/vkknqylzvzlu
branch
from
f955649 to
2ab2090
Compare
9 tasks
Contributor
|
uh, I think this should be the right job: |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 26, 2025
Port the `#![windows_subsystem]` attribute to the new attribute system try-job: x86_64-msvc
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Close, missing a -1. |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 27, 2025
Port the `#![windows_subsystem]` attribute to the new attribute system try-job: x86_64-msvc-1
Contributor
|
oops, thanks jieyou! |
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 27, 2025
…r=jdonszelmann Port the `#![windows_subsystem]` attribute to the new attribute system Part of rust-lang#131229. I think it's worth running the Windows test suite before merging that (I don't have the rights for this).
bors
added a commit
that referenced
this pull request
Nov 27, 2025
Rollup of 8 pull requests Successful merges: - #147071 (constify from_fn, try_from_fn, try_map, map) - #148930 (tweak editor configs) - #149320 (-Znext-solver: normalize expected function input types when fudging) - #149363 (Port the `#![windows_subsystem]` attribute to the new attribute system) - #149378 (make run-make tests use 2024 edition by default) - #149381 (Add `impl TrustedLen` on `BTree{Map,Set}` iterators) - #149388 (remove session+blob decoder construction) - #149390 (`rust-analyzer` subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #131229.
r? @jdonszelmann
I think it's worth running the Windows test suite before merging that (I don't have the rights for this).