docs: restructure functional-routing #1872

shamshodisaev · 2025-11-25T15:27:03Z

Title of Pull Request

Restructure functional routing task

🤔 This is a

⚙️ Update to an existing task

Description

Brief Overview:
restructure functional routing task
Implementation Approach:
- Application requirements -> functional requirements
- Add 404 feature
- Split points across features
- update penalties

Additional Information

https://github.com/rolling-scopes-school/tasks/blob/feature/react-functional-routing-task/react/modules/tasks/functional-routing.md

Checklist

✅ I have performed a self-review of my own code.
📝 I have commented my code, particularly in hard-to-understand areas.
🔧 I have made corresponding changes to the documentation (if applicable).
🚫 My changes generate no new warnings or errors.

kravaring

Just some minor comments, in overall looks good

kravaring · 2025-11-25T19:56:13Z

react/modules/tasks/functional-routing.md

+
+**As a** user
+**I want** to navigate through pages of search results
+**So that** I can view more items and keep my place in the app


'and keep my place in the app' => 'keep track of the viewed items'?
Not sure, but the initial verbiage sounds confusing :(

right, updated 0fce00a

kravaring · 2025-11-25T19:58:02Z

react/modules/tasks/functional-routing.md

+
+**As a** user
+**I want** to view item details alongside the search results
+**So that** I can see more information without losing my place in the list


Maybe 'losing current position'?

Margaryta-Maletz

I believe, we should discuss my comments tomorrow

Margaryta-Maletz · 2025-12-02T15:06:36Z

react/modules/tasks/functional-routing.md

-   - Create an About page with application author information
-   - Include a link to the RS School React course
-   - Add navigation to reach the About page from the main application
+## Functional Requirements (max **100 points**)


Row 9:
Focus on routing and functional components. Remove any button or functionality which throws exceptions unnecessarily.

What is our decision: delete or not delete?

Margaryta-Maletz · 2025-12-02T15:09:37Z

react/modules/tasks/functional-routing.md

+- Pagination controls are visible after items are loaded.
+- Changing the page updates the URL with the correct `page` parameter.
+- The visible page matches the page in the URL at all times.


Suggested change

- Pagination controls are visible after items are loaded.

- Changing the page updates the URL with the correct `page` parameter.

- The visible page matches the page in the URL at all times.

- Pagination controls are visible after items are loaded. [10 points]

- Changing the page updates the URL with the correct `page` parameter. [10 points]

- The visible page matches the page in the URL at all times. [10 points]

Margaryta-Maletz · 2025-12-02T15:13:54Z

react/modules/tasks/functional-routing.md

+- **Then** the current page is displayed in the URL as a query parameter (e.g., `?page=2`)
+- **And** the pagination controls reflect the current page
+- **And** pagination appears only after the list of items is loaded
+


I would add something else about behavior when changing the input in the search bar. The page should be changed to 1. What do you think about that?

Margaryta-Maletz · 2025-12-02T18:16:08Z

react/modules/tasks/functional-routing.md

+
+- **Given** I am viewing the item list
+- **When** I navigate to a different page using pagination controls
+- **Then** the current page is displayed in the URL as a query parameter (e.g., `?page=2`)


Suggested change

- **Then** the current page is displayed in the URL as a query parameter (e.g., `?page=2`)

- **Then** the current page is displayed in the URL as a query parameter (e.g., `?page=2` or `/:page` )

Margaryta-Maletz · 2025-12-02T18:18:14Z

react/modules/tasks/functional-routing.md

+- Clicking an item opens a details panel on the right, using `<Outlet>`.
+- The left side always shows the list of results.
+- A loading indicator is visible while details are loading.
+- The details panel can be closed via a close button or by clicking the main panel.
+- The URL always reflects the current page and selected item.
+- On initial load, no item is selected and the details panel is closed.


Suggested change

- Clicking an item opens a details panel on the right, using `<Outlet>`.

- The left side always shows the list of results.

- A loading indicator is visible while details are loading.

- The details panel can be closed via a close button or by clicking the main panel.

- The URL always reflects the current page and selected item.

- On initial load, no item is selected and the details panel is closed.

- Clicking an item opens a details panel on the right, using `<Outlet>`. [8 points]

- The left side always shows the list of results. [8 points]

- A loading indicator is visible while details are loading. [8 points]

- The details panel can be closed via a close button or by clicking the main panel. [8 points]

- The URL always reflects the current page and selected item. [8 points]

- On initial load, no item is selected and the details panel is closed. [5 points]

Margaryta-Maletz · 2025-12-02T18:19:33Z

react/modules/tasks/functional-routing.md

+- The About page displays author information and a link to the RS School React course.
+- The About page is accessible via a navigation link from the main application.


Suggested change

- The About page displays author information and a link to the RS School React course.

- The About page is accessible via a navigation link from the main application.

- The About page displays author information and a link to the RS School React course. [5 points]

- The About page is accessible via a navigation link from the main application. [5 points]

Margaryta-Maletz · 2025-12-02T18:19:44Z

react/modules/tasks/functional-routing.md

+- The About page displays author information and a link to the RS School React course.
+- The About page is accessible via a navigation link from the main application.
+
+### Feature 4: 404 Page (**10 points**)


Suggested change

### Feature 4: 404 Page (**10 points**)

### Feature 4: 404 Page (**15 points**)

Margaryta-Maletz · 2025-12-02T18:20:12Z

react/modules/tasks/functional-routing.md

+- A 404 page is displayed for all unknown or non-existing routes.
+- The 404 page contains a clear message that the page was not found.
+- The 404 page provides a navigation option (e.g., button or link) to return to the main app.


Suggested change

- A 404 page is displayed for all unknown or non-existing routes.

- The 404 page contains a clear message that the page was not found.

- The 404 page provides a navigation option (e.g., button or link) to return to the main app.

- A 404 page is displayed for all unknown or non-existing routes. [5 points]

- The 404 page contains a clear message that the page was not found. [5 points]

- The 404 page provides a navigation option (e.g., button or link) to return to the main app. [5 points]

Margaryta-Maletz · 2025-12-02T18:24:01Z

react/modules/tasks/functional-routing.md

+- Pick one router and follow its official documentation for setup and navigation.
+
+### Penalties
+


Need to discuss this penalties

** Technical Requirements **
Component Conversion ... - 50 points
custom hook for localStorage operations ... -20 points

Margaryta-Maletz · 2025-12-02T18:25:18Z

react/modules/tasks/functional-routing.md

  - Details panel should be closed either on the "close" button click or on the main panel click - **10**
 - About page is implemented with author information and a link to the RS School React course - **5**
 - 404 is implemented - **5**
 - New tests are added for the new functionality - **15**


Delete cross-check score from 182 to 192 rows

docs: restructure & add feature

f90631b

shamshodisaev requested review from SpaNb4 and kravaring as code owners November 25, 2025 15:27

github-actions bot added the react label Nov 25, 2025

kravaring reviewed Nov 25, 2025

View reviewed changes

docs: update ACs

0fce00a

shamshodisaev requested a review from kravaring December 2, 2025 15:01

Margaryta-Maletz requested changes Dec 2, 2025

View reviewed changes

	- Then the current page is displayed in the URL as a query parameter (e.g., `?page=2`)
	- Then the current page is displayed in the URL as a query parameter (e.g., `?page=2` or `/:page` )

		- The About page displays author information and a link to the RS School React course.
		- The About page is accessible via a navigation link from the main application.

	### Feature 4: 404 Page (10 points)
	### Feature 4: 404 Page (15 points)

		- Pick one router and follow its official documentation for setup and navigation.

		### Penalties

docs: restructure functional-routing #1872

Are you sure you want to change the base?

docs: restructure functional-routing #1872

Conversation

shamshodisaev commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Title of Pull Request

🤔 This is a

Description

Additional Information

Checklist

Uh oh!

kravaring left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Margaryta-Maletz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shamshodisaev commented Nov 25, 2025 •

edited

Loading